Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

soroban-cli: Remove ALL RPC Related Code and Workflows #1198

Merged
merged 10 commits into from
Feb 14, 2024
Merged

Conversation

stellarsaur
Copy link
Contributor

What

Related to the Soroban RPC/CLI repo split.

This PR removes all Soroban RPC integration tests, workflows, crates, and code. In fact, this repo now doesn't use Golang at all. Specifically:

  • Removed all code under cmd/soroban-rpc/ including integration tests
    • soroban-rpc repo will be responsible for integration tests since the integration tests in cmd/soroban-rpc/internal/test are for the functionality of Soroban RPC
  • Removed Soroban RPC & Golang related workflows
  • Removed Soroban RPC & Golang related Makefile commands
  • Updated check_dependencies script
  • Use soroban-rpc crate from soroban-rpc repo instead
  • Update e2e.yml system test workflow to checkout Soroban RPC from soroban-rpc

Why

Now that we've functionally split the repos, this PR cleans up any remaining references to Soroban RPC in the soroban-tools repo. The soroban-rpc repo should be responsible for all RPC related code instead of this repo.

@leighmcculloch
Copy link
Member

The README needs updating too.

@stellarsaur stellarsaur marked this pull request as ready for review February 14, 2024 01:07
@stellarsaur stellarsaur merged commit 4febbe2 into main Feb 14, 2024
14 checks passed
@stellarsaur stellarsaur deleted the rpc-prune branch February 14, 2024 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants