Update references in end-to-end tests to point to the latest releases #1208
Conversation
.github/workflows/e2e.yml
Outdated
|
|
||
| # triggers system test to log out details from quickstart's logs and test steps | ||
| SYSTEM_TEST_VERBOSE_OUTPUT: "true" | ||
|
|
||
| # the soroban test cases will compile various contracts from the examples repo | ||
| SYSTEM_TEST_SOROBAN_EXAMPLES_GIT_HASH: "v20.0.0" | ||
| SYSTEM_TEST_SOROBAN_EXAMPLES_GIT_HASH: "v20.2.0" |
There was a problem hiding this comment.
this tag is a bit old from Jan, i noticed sdk 20.3.0 bump was pushed to the examples contracts 2 weeks ago, and cli repo is on 20.3.0 sdk, @sisuresh , will there be a new tag on soroban-examples to capture that sdk ver bump? may be good for e2e tests to ref the equivalent hash 782458d31395b0191ac40c9572ac53f13f573aa3 for now, so it will compile contracts at same sdk level, which it then sends to cli commands.
| name: checkout system-test | ||
| with: | ||
| repository: stellar/system-test | ||
| ref: ${{ env.SYSTEM_TEST_GIT_REF }} | ||
| path: system-test | ||
| - uses: actions/checkout@v3 | ||
| - uses: actions/checkout@v4 |
There was a problem hiding this comment.
I don't think need to checkout local copy of soroban-tools, cli refs to gh workspace directory, and rpc refs soroban-rpc repo now
There was a problem hiding this comment.
I think it's needed for pathing? unsure though
There was a problem hiding this comment.
system-test make/build will not be referring to the soroban-tools path, it resolves rpc and cli source paths from the urls or local paths set on SYSTEM_TEST_SOROBAN_CLI_REF and SYSTEM_TEST_SOROBAN_RPC_REF
There was a problem hiding this comment.
does soroban-cli need to use a pinned ref to soroban-rpc for testing purposes? current config on SYSTEM_TEST_SOROBAN_RPC_REF is not spec'ing a git ref on the repo url, using mainline/master ref then.
|
the e2e is failing to build the system-test image based on cli source location, SYSTEM_TEST_SOROBAN_CLI_REF should point at the gha workspace folder that soroban-cli source is checked out, which I think in this case of it being the pr repo, can be obtained from just |
…1203) * Repoint RPC references to crates instead of GH * Repoint GHA to use one with macOS workarounds --------- Co-authored-by: Alfonso Acosta <[email protected]> Co-authored-by: Elizabeth Engelman <[email protected]> Co-authored-by: Willem Wyndham <[email protected]>
Shaptic
force-pushed
the
e2e-ref-fixups
branch
from
8b903bc to
77fcea1
Compare
Shaptic
force-pushed
the
e2e-ref-fixups
branch
from
77fcea1 to
e3f0295
Compare
What
See title.
Why
Confirm that tests pass against current latest release.
Known limitations
n/a