Make builds and tests consistent #1222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elizabethengelman
pushed a commit
to AhaLabs/stellar-cli
that referenced
this pull request
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Change the install make target to use the lock file, by adding --locked to all cargo install commands. Also encourage --locked usage elsewhere in CLI help output, and fix old make targets that are no longer needed since the split.
Why
Cargo install won't use the Cargo.lock file at all unless the --locked option is passed. This means that installs in CI are pulling in whatever the latest versions of software that match the Cargo.toml specification. This allows any developer of any dependency to have control over what runs in CI, or on developer machines. It is the main reason to rely on the Cargo.lock file and only update the lock file intentionally.
Cargo build automatically uses the lock file and only modifies it if it needs modifying. Install is one command that unfortunately doesn't use the lock file at all.
Recently the fact that the lock file wasn't in use caused CI to break: