Fix/update init template #1224
Merged
Fix/update init template #1224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elizabethengelman
force-pushed
the
fix/update-init-template
branch
from
24c49ad to
1815c60
Compare
elizabethengelman
force-pushed
the
fix/update-init-template
branch
from
0d6cba6 to
195d354
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
A companion PR to stellar-deprecated/soroban-docs#730. A few tweaks to the
initcommand and template to make it a bit easier to work with.initto be called from within an existing directory - previously we were looking at the passed-in directory name to use as the "name" inpackage.json. But if the user callssoroban contract init ./we wouldn't have a project name. This PR handles this scenario..soroban/contract-idsfile in the template with a.gitkeepWhy
While updating the Getting Started Guide doc, I discovered some things that could change to make
soroban contract inita bit nicer to work with.Known limitations
N/A