Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/init/merge readmes #1228

Merged
merged 4 commits into from
Mar 12, 2024

Conversation

elizabethengelman
Copy link
Contributor

@elizabethengelman elizabethengelman commented Feb 29, 2024

What

For soroban contract init if the user passes in the --frontend-template flag, the init command will now merge the built-in base README with the frontend template's readme.

Why

This is helpful so that the user has access to both of the READMEs while developing their project.

Known limitations

N/A

@elizabethengelman elizabethengelman force-pushed the feat/init/merge-readmes branch from 9d0063c to ddff2b9 Compare March 8, 2024 18:28
@elizabethengelman elizabethengelman force-pushed the feat/init/merge-readmes branch from ddff2b9 to cf0a3ad Compare March 8, 2024 18:46
@elizabethengelman elizabethengelman marked this pull request as ready for review March 8, 2024 18:59
@elizabethengelman elizabethengelman force-pushed the feat/init/merge-readmes branch from fe1e829 to a347e67 Compare March 8, 2024 19:58
@willemneal willemneal requested a review from chadoh March 11, 2024 19:09
Copy link
Contributor

@chadoh chadoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay in reviewing!

@elizabethengelman elizabethengelman merged commit 5acdda2 into stellar:main Mar 12, 2024
13 checks passed
@elizabethengelman elizabethengelman deleted the feat/init/merge-readmes branch March 12, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants