Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Change the cli --is-view env var to be
SOROBAN_INVOKE_VIEW
instead ofSYSTEM_TEST_VERBOSE_OUTPUT
, retaining support for the previous env var for backwards compatibility.Why
In #1194 when the env var was added it appears we accidentally named it a name that doesn't have anything to do with the option. The env var is actually the name of an env var used in the system test suite, so I'm going to guess that a find all and rename went awry and maybe renamed an env var here that shouldn't have been.
At the moment two env vars are attached to the option, and only the second one appears to be useable in my testing, as the second env parameter overrides the first.
This change is not a breaking change and can be released in a patch release as a bug fix.
The old env var is not advertised in the help output.
Example
Before
After