fetch possible example contracts at compile time #1244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willemneal
reviewed
Mar 6, 2024
elizabethengelman
force-pushed
the
fix/fetch-example-contracts-at-compile-time
branch
from
efa15ad to
46cbe05
Compare
willemneal
reviewed
Mar 6, 2024
willemneal
reviewed
Mar 6, 2024
willemneal
reviewed
Mar 6, 2024
Co-authored-by: Willem Wyndham <[email protected]>
Co-authored-by: Willem Wyndham <[email protected]>
elizabethengelman
changed the title
willemneal
reviewed
Mar 12, 2024
willemneal
reviewed
Mar 12, 2024
willemneal
approved these changes
Mar 12, 2024
elizabethengelman
force-pushed
the
fix/fetch-example-contracts-at-compile-time
branch
from
8989e32 to
876d401
Compare
elizabethengelman
deleted the
fix/fetch-example-contracts-at-compile-time
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This came out of #1229 - the cli was displaying an error when it could not fetch the example contracts from
soroban-examples, every time a user ran soroban. This was because the way we had setup the clap cli help info, it would try to fetch valid example contracts everytime help was invoked.#1232 moved the examples back to being hardcoded, and this PR bakes the list of example contracts into the package - fetching the list at compile time.