Code

Feat/ledger signing#1278

Code

Merged

willemneal merged 87 commits intostellar:mainstellar/stellar-cli:mainfrom AhaLabs:feat/ledger-signingAhaLabs/stellar-cli:feat/ledger-signingCopy head branch name to clipboardMay 27, 2024

+2,293-38

Commits

Commits on Mar 19, 2024

• Exploring how to interact with Ledger from rust code

  elizabethengelman

  committed
  4f8e15b

  Copy full SHA for 4f8e15b

Commits on Mar 20, 2024

• WIP: get_public_key works, but needs to be cleaned up

  elizabethengelman

  committed
  50e5e5f

  Copy full SHA for 50e5e5f

• Clean up: get_public_key

  elizabethengelman

  committed
  852114e

  Copy full SHA for 852114e

• Clean up: remove unused tests, etc

  elizabethengelman

  committed
  db1c976

  Copy full SHA for db1c976

Commits on Mar 22, 2024

• WIP: start the speculos emulator via docker

  elizabethengelman

  committed
  e24d8a6

  Copy full SHA for e24d8a6

Commits on Mar 27, 2024

• WIP: start speculos via docker and include some default elf files

  elizabethengelman

  committed
  0d1c9e7

  Copy full SHA for 0d1c9e7

Commits on Mar 28, 2024

• Allow for stopping the emulator

  elizabethengelman

  committed
  37b2a24

  Copy full SHA for 37b2a24

• Make get_public_key async

  Show description for c68c40d
  elizabethengelman

  committed
  c68c40d

  Copy full SHA for c68c40d

• WIP: Allow get_public_key to use Exchange trait to get the transport

  Show description for 1f51f3e
  elizabethengelman

  committed
  1f51f3e

  Copy full SHA for 1f51f3e

• Pass transport into get_public_key_with_display_flag

  elizabethengelman

  committed
  b74f972

  Copy full SHA for b74f972

• Create a Ledger struct that takes in a generic that implements Exchange

  elizabethengelman

  committed
  7c1898b

  Copy full SHA for 7c1898b

• Add get_public_key_with_display_flag to Ledger implementation

  elizabethengelman

  committed
  d477ce8

  Copy full SHA for d477ce8

• WIP: try to connect ledger struct to emulator transport intead of the ledger device

  elizabethengelman

  committed
  6780f4d

  Copy full SHA for 6780f4d

• WIP: connected to the emulator

  elizabethengelman

  committed
  b968fc7

  Copy full SHA for b968fc7

Commits on Apr 1, 2024

• Add stellarNanoApp.elf

  elizabethengelman

  committed
  614e75b

  Copy full SHA for 614e75b

• Cleanup

  elizabethengelman

  committed
  404dd46

  Copy full SHA for 404dd46

• Add get_app_configuration fn

  elizabethengelman

  committed
  9c36b4c

  Copy full SHA for 9c36b4c

Commits on Apr 3, 2024

• Add sign_transaction_hash fn

  elizabethengelman

  committed
  e39d95b

  Copy full SHA for e39d95b

Commits on Apr 4, 2024

• Allow for enabling tx hash signing on the emulator

  elizabethengelman

  committed
  63bafad

  Copy full SHA for 63bafad

• WIP - approve the tx on the device

  elizabethengelman

  committed
  0f96420

  Copy full SHA for 0f96420

Commits on Apr 8, 2024

• WIP signing a tx

  elizabethengelman

  committed
  d249506

  Copy full SHA for d249506

• wip sign tx

  elizabethengelman

  committed
  691102b

  Copy full SHA for 691102b

Commits on Apr 9, 2024

• not sure which is right

  elizabethengelman

  committed
  98a0ffa

  Copy full SHA for 98a0ffa

Commits on Apr 11, 2024

• Making progress

  Show description for 28f999d
  elizabethengelman

  committed
  28f999d

  Copy full SHA for 28f999d

• cleanup

  elizabethengelman

  committed
  5f422ef

  Copy full SHA for 5f422ef

• Up the TransportZemuHttp timeout

  elizabethengelman

  committed
  b3a1a1c

  Copy full SHA for b3a1a1c

• Cleanup

  elizabethengelman

  committed
  16ca7a5

  Copy full SHA for 16ca7a5

• Update the expected sign_transaction response hex

  elizabethengelman

  committed
  1ea114f

  Copy full SHA for 1ea114f

• Fix tests

  elizabethengelman

  committed
  e2b6e0f

  Copy full SHA for e2b6e0f

• Remove unused imports

  elizabethengelman

  committed
  692e659

  Copy full SHA for 692e659

• Move app code into lib.rs

  elizabethengelman

  committed
  84d2b07

  Copy full SHA for 84d2b07

Commits on Apr 15, 2024

• Make LedgerSigner adhere to Stellar signer trait

  elizabethengelman

  committed
  0d5d159

  Copy full SHA for 0d5d159

Commits on Apr 16, 2024

• Check in Cargo.lock

  elizabethengelman

  committed
  dcc34ab

  Copy full SHA for dcc34ab

• Clippy

  elizabethengelman

  committed
  fb9f653

  Copy full SHA for fb9f653

Commits on Apr 17, 2024

• WIP: start to use testcontainers, but it's flakey

  Show description for d8a5dc0
  elizabethengelman

  committed
  d8a5dc0

  Copy full SHA for d8a5dc0

• Getting closer, this isn't as flakey but has some sleeps in there

  elizabethengelman

  committed
  db06ddc

  Copy full SHA for db06ddc

Commits on Apr 18, 2024

• Use testcontainers for all ledger tests

  elizabethengelman

  committed
  e6cbf77

  Copy full SHA for e6cbf77

• Move speculos testcontainer setup to its own file

  elizabethengelman

  committed
  a367a58

  Copy full SHA for a367a58

• Remove docker.rs and emulator.rs to use testcontainers instead

  elizabethengelman

  committed
  bd51844

  Copy full SHA for bd51844

Commits on Apr 22, 2024

• wip

  elizabethengelman

  committed
  0a3fdaf

  Copy full SHA for 0a3fdaf

• Cleanup

  elizabethengelman

  committed
  fd402fc

  Copy full SHA for fd402fc

• Checkin Cargo.lock

  elizabethengelman

  committed
  396bc1f

  Copy full SHA for 396bc1f

• Merge branch 'main' into feat/ledger-signing

  elizabethengelman

  committed
  0b7034e

  Copy full SHA for 0b7034e

• Clippy

  elizabethengelman

  committed
  8b53aad

  Copy full SHA for 8b53aad

• Merge branch 'main' into feat/ledger-signing

  elizabethengelman

  authored
  ecfa66a

  Copy full SHA for ecfa66a

Commits on Apr 29, 2024

• Make sure that the ledger's ready text is displayed before continuing with tests

  elizabethengelman

  committed
  868b9d6

  Copy full SHA for 868b9d6

• Try waiting until the screen has changed before sending another button req

  elizabethengelman

  committed
  bb6c4ab

  Copy full SHA for bb6c4ab

• Fix issue with cc 1.0.86 and macos builds and build binaries on all (stellar#1287)

  Show description for fb773e7
  

  leighmcculloch

  authored and

  elizabethengelman

  committed
  fb773e7

  Copy full SHA for fb773e7

• Cleanup

  elizabethengelman

  committed
  11961ae

  Copy full SHA for 11961ae

• Apply suggestions from code review

  Show description for 25be1e6
  

  elizabethengelman

  and

  willemneal

  committed
  25be1e6

  Copy full SHA for 25be1e6

• Address PR feedback

  elizabethengelman

  committed
  3fb067f

  Copy full SHA for 3fb067f

• Separate emulator-dependent tests

  elizabethengelman

  committed
  bf6a870

  Copy full SHA for bf6a870

• Merge branch 'main' into feat/ledger-signing

  elizabethengelman

  authored
  a2eaeb6

  Copy full SHA for a2eaeb6

• Run emulator-dependent tests in a separate workflow

  elizabethengelman

  committed
  1ac9400

  Copy full SHA for 1ac9400

• chore: move feature to mod declaration

  willemneal

  committed
  8a097af

  Copy full SHA for 8a097af

Commits on Apr 30, 2024

• Add unit tests to lib that mock out http requests

  elizabethengelman

  committed
  7829271

  Copy full SHA for 7829271

• Merge branch 'main' into feat/ledger-signing

  elizabethengelman

  authored
  e1631d7

  Copy full SHA for e1631d7

Commits on May 1, 2024

• Merge branch 'main' into feat/ledger-signing

  elizabethengelman

  authored
  b44a9b4

  Copy full SHA for b44a9b4

• Merge branch 'main' into feat/ledger-signing

  elizabethengelman

  authored
  b5fedfd

  Copy full SHA for b5fedfd

Commits on May 2, 2024

• Merge branch 'main' into feat/ledger-signing

  elizabethengelman

  authored
  ba0a75c

  Copy full SHA for ba0a75c

• Cleanup

  elizabethengelman

  committed
  a5b6f9b

  Copy full SHA for a5b6f9b

• Rename TransportZemuHttp -> EmulatorHttpTransport

  Show description for 8829da2
  elizabethengelman

  committed
  8829da2

  Copy full SHA for 8829da2

Commits on May 3, 2024

• Update error handling

  elizabethengelman

  committed
  feec1a0

  Copy full SHA for feec1a0

• Fix SignatureHint

  elizabethengelman

  committed
  40d978e

  Copy full SHA for 40d978e

• Add get_transport fn back in

  elizabethengelman

  committed
  8026558

  Copy full SHA for 8026558

• Update one last error

  elizabethengelman

  committed
  02f840e

  Copy full SHA for 02f840e

Commits on May 7, 2024

• Cleanup imports

  elizabethengelman

  committed
  a5eca37

  Copy full SHA for a5eca37

Commits on May 8, 2024

• Merge branch 'main' into feat/ledger-signing

  elizabethengelman

  authored
  876f81a

  Copy full SHA for 876f81a

• Merge branch 'main' into feat/ledger-signing

  elizabethengelman

  authored
  0c3274b

  Copy full SHA for 0c3274b

• feat: update signer interface in stellar-ledger

  willemneal

  committed
  1d9a93f

  Copy full SHA for 1d9a93f

• feat: add Blob trait and simplify API

  Show description for a9981eb
  willemneal

  committed
  a9981eb

  Copy full SHA for a9981eb

Commits on May 9, 2024

• Merge branch 'main' into feat/ledger-signing

  elizabethengelman

  authored
  64f5493

  Copy full SHA for 64f5493

Commits on May 14, 2024

• Merge branch 'main' into feat/ledger-signing

  elizabethengelman

  committed
  ff91690

  Copy full SHA for ff91690

• Merge remote-tracking branch 'AhaLabs/feat/ledger-signing' into feat/ledger-signing

  willemneal

  committed
  36cc011

  Copy full SHA for 36cc011

• fix: fmt

  willemneal

  committed
  f571eca

  Copy full SHA for f571eca

Commits on May 15, 2024

• Apply suggestions from code review

  Show description for c3f63a1
  

  willemneal

  and

  elizabethengelman

  authored
  c3f63a1

  Copy full SHA for c3f63a1

• fix: blob to make async_trait happy

  Show description for 91e83d1
  willemneal

  committed
  91e83d1

  Copy full SHA for 91e83d1

Commits on May 16, 2024

• fix: tests

  willemneal

  committed
  69069a0

  Copy full SHA for 69069a0

• fix: pass emulator tests

  willemneal

  committed
  091beff

  Copy full SHA for 091beff

Commits on May 17, 2024

• Merge pull request #23 from AhaLabs/feat/ledger-signer-v1

  Show description for ec977c9
  elizabethengelman

  authored
  ec977c9

  Copy full SHA for ec977c9

Commits on May 21, 2024

• Merge branch 'main' into feat/ledger-signing

  elizabethengelman

  authored
  d4d0d41

  Copy full SHA for d4d0d41

Commits on May 22, 2024

• Add to stellar-ledger crate readme

  elizabethengelman

  committed
  53774fe

  Copy full SHA for 53774fe

• Cleanup: comments, tests & clippy

  elizabethengelman

  committed
  180757b

  Copy full SHA for 180757b

• Merge branch 'main' into feat/ledger-signing

  elizabethengelman

  authored
  8129f16

  Copy full SHA for 8129f16

Commits on May 27, 2024

• Merge remote-tracking branch 'origin/main' into feat/ledger-signing

  willemneal

  committed
  30d15e6

  Copy full SHA for 30d15e6

• Update cmd/crates/stellar-ledger/README.md

  Show description for 0f8586f
  

  willemneal

  and

  chadoh

  authored
  0f8586f

  Copy full SHA for 0f8586f

• Update cmd/soroban-cli/src/commands/contract/invoke.rs

  willemneal

  authored
  66af953

  Copy full SHA for 66af953