fix: depend on a real, deployed RPC version #1284
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`main` and the latest released version of the CLI are totally broken because the 3.3.5 release of the RPC was yanked. While we are waiting for that yank to be rolled back (it was related to a bug in simulation, which does not introduce security vulnerabilities and which did not need to be yanked), rolling back the RPC version _may_ work well enough. I say "may" because I don't really know if there are other dependencies on the latest RPC here. Let's see if CI passes, i guess?
|
The RPC dep has been unyanked so we shouldn't need to do this now. Please reopen if I'm misunderstanding. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Roll back RPC dependency
Why
mainand the latest released version of the CLI are totally brokenbecause the 3.3.5 release of the RPC was yanked. While we are waiting
for that yank to be rolled back (it was related to a bug in simulation,
which does not introduce security vulnerabilities and which did not need
to be yanked), rolling back the RPC version may work well enough. I
say "may" because I don't really know if there are other dependencies on
the latest RPC here. Let's see if CI passes, i guess?
Known limitations
Unknown!