Fix issue with cc 1.0.86 and macos builds and build binaries on all #1287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leighmcculloch
changed the title
fnando
approved these changes
Apr 23, 2024
elizabethengelman
pushed a commit
to AhaLabs/stellar-cli
that referenced
this pull request
Apr 29, 2024
…tellar#1287) * Fix issue with cc 1.0.86 and macos builds * fix * fix * update to 1.0.88 * try 1.0.95
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Upgrade cc dep to v1.0.95, and build binaries in PRs.
Why
We've had some cases where binary builds broke. We can build binaries on every PR to catch issues like this, or if that is too frequent we can build just on the main branch, or once daily.
In this case there's a bug in cc 1.0.86 causing build failure on macos.
Related issue: sfackler/rust-openssl#2184
Related discussion: https://stellarfoundation.slack.com/archives/C04B02ABF37/p1713305492962519?thread_ts=1712078124.854589&cid=C04B02ABF37