Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: update to protocol 21 #1292

Merged
merged 21 commits into from
Apr 30, 2024
Merged

feat!: update to protocol 21 #1292

merged 21 commits into from
Apr 30, 2024

Conversation

willemneal
Copy link
Member

No description provided.

@kalepail
Copy link
Contributor

Are we going to need to create some sort of logic for installing futurenet, testnet and mainnet enabled cli versions or branches?

@willemneal
Copy link
Member Author

@leighmcculloch I remember we discussed something similar, but perhaps we should have different branches that would act as a beta/nightly for testnet and futurenet?

@leighmcculloch
Copy link
Member

leighmcculloch commented Apr 25, 2024

Are we going to need to create some sort of logic for installing futurenet, testnet and mainnet enabled cli versions or branches?

If you need a version of the CLI that only works on protocol 20, you can install v20 of the CLI. The XDR will always be binary backwards compatible from v21 to v20 so all v20 XDRs should be decodable by v21.

cargo install --locked --version '^20' soroban-cli

I think we could add a version modifier and support multiple versions installed or old behavior, such as:

soroban +20 contract invoke
soroban +21 contract invoke

But that functionality doesn't exist today, and because of the complexity to add something like that we need more information about its usefulness.

@leighmcculloch leighmcculloch marked this pull request as ready for review April 29, 2024 23:40
@leighmcculloch leighmcculloch merged commit 49e053e into main Apr 30, 2024
18 checks passed
@leighmcculloch leighmcculloch deleted the feat-update-deps branch April 30, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Extending wasm-hashes is broken on the main branch for futurenet (protocol 21)
4 participants