Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed extra output line in optimization #1315

Merged
merged 1 commit into from
May 7, 2024

Conversation

leighmcculloch
Copy link
Member

@leighmcculloch leighmcculloch commented May 7, 2024

What

Removed output line in optimization saying that a file will be written.

Example

Before

$ soroban contract optimize --wasm ./out/webauthn_factory.wasm
Reading: ./out/webauthn_factory.wasm (661 bytes)
Writing to: ./out/webauthn_factory.optimized.wasm...
Optimized: ./out/webauthn_factory.optimized.wasm (586 bytes)

After

$ soroban contract optimize --wasm ./out/webauthn_factory.wasm
Reading: ./out/webauthn_factory.wasm (661 bytes)
Optimized: ./out/webauthn_factory.optimized.wasm (586 bytes)

Why

It is immediately followed with an output line that the file has been written, and the duplicate lines is unnecessary noise in the output.

@leighmcculloch leighmcculloch requested a review from fnando May 7, 2024 10:27
@leighmcculloch leighmcculloch marked this pull request as ready for review May 7, 2024 10:28
@leighmcculloch leighmcculloch enabled auto-merge (squash) May 7, 2024 10:28
@leighmcculloch leighmcculloch merged commit 9bc48fd into main May 7, 2024
18 of 19 checks passed
@leighmcculloch leighmcculloch deleted the pythagorical-intertwiningly branch May 7, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants