Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: switch to stderr directly for when account already exists #1328

Merged
merged 1 commit into from
May 16, 2024
Merged

fix: switch to stderr directly for when account already exists #1328

merged 1 commit into from
May 16, 2024

Conversation

willemneal
Copy link
Member

What

Switch from tracing::warn to eprintln

Why

It didn't make it into stderr in tests.

Known limitations

[TODO or N/A]

@willemneal willemneal requested a review from chadoh May 16, 2024 15:49
chadoh
chadoh approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@chadoh chadoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Such a small change! Can you explain it a little? Why did tracing::warn break the test?

@chadoh chadoh merged commit 8db6145 into stellar:main May 16, 2024
18 checks passed
@chadoh chadoh deleted the fix/CI branch May 16, 2024 17:21
@chadoh
Copy link
Contributor

chadoh commented May 16, 2024

I see your what/why, but I'm curious to know more. Why had it been tracing::warn?

leighmcculloch
leighmcculloch reviewed May 16, 2024
View reviewed changes
Copy link
Member

@leighmcculloch leighmcculloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably fix the tests, rather change the output. I think we want the output to go to the warning logs don't we?

@willemneal
Copy link
Member Author

willemneal commented May 17, 2024 •
edited
Loading

Yeah but this was blocked other PRs and it should go towards logs. Rather not sure why the log wasn't being picked up by stderr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leighmcculloch leighmcculloch leighmcculloch left review comments

@chadoh chadoh chadoh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
DevX
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@willemneal @chadoh @leighmcculloch