Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move testcontainers dep to dev-deps in Cargo.toml #1377

Merged

Conversation

elizabethengelman
Copy link
Contributor

@elizabethengelman elizabethengelman commented Jun 17, 2024

What

Move testcontainers dependency under the dev-deps in Cargo.toml

Why

Testcontainers is only used in testing.

Known limitations

We will likely want to revisit the dep mismatches so that we can use a release of testcontainers instead of a specific git sha in the future

@elizabethengelman elizabethengelman marked this pull request as ready for review June 17, 2024 15:58
@elizabethengelman elizabethengelman self-assigned this Jun 17, 2024
@willemneal willemneal merged commit 728c79f into stellar:main Jun 17, 2024
24 checks passed
@willemneal willemneal deleted the fix/move-testcontainers-to-dev-deps branch June 17, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants