Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for alias to stellar contract extend|read|restore. #1413

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Add support for alias to stellar contract extend|read|restore. #1413

merged 1 commit into from
Jun 27, 2024

Conversation

fnando
Copy link
Member

@fnando fnando commented Jun 26, 2024

What

Add support for alias to stellar contract extend|read|restore.

$ stellar contract read --id alice --global --network standalone --source alice --durability persistent
LedgerKeyContractInstance,"{""hash"":""d68f72ee0e95c63263e64e1802d0bb511461e0948da7fe355bcfe16163e78b95""}",360380,2433979

$ stellar contract read --id CAYXES5COIN3UEAQ7QM6CNRKQAXGW45YHRH32GHWAMRLI5AR7PWL7OTS --global --network standalone --source alice --durability persistent
LedgerKeyContractInstance,"{""hash"":""d68f72ee0e95c63263e64e1802d0bb511461e0948da7fe355bcfe16163e78b95""}",360380,2433979

Why

So users can pass in an alias, rather than the contract id.

Known limitations

N/A

@fnando fnando requested a review from willemneal June 26, 2024 23:50
@fnando fnando force-pushed the contract-extend-read-restore-with-alias branch from 5cf9596 to e242c85 Compare June 26, 2024 23:51
@fnando fnando mentioned this pull request Jun 26, 2024
Closed
7 tasks
willemneal
willemneal approved these changes Jun 27, 2024
View reviewed changes
Copy link
Member

@willemneal willemneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question about the new error case

cmd/soroban-cli/src/commands/contract/extend.rs Show resolved Hide resolved
@fnando fnando merged commit 1fae6c1 into main Jun 27, 2024
25 checks passed
@fnando fnando deleted the contract-extend-read-restore-with-alias branch June 27, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willemneal willemneal willemneal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
DevX
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fnando @willemneal