Feat: add stellar ledger as signer #1415
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willemneal
force-pushed
the
feat/add_stellar_ledger
branch
from
c338fdb to
bc25c6b
Compare
willemneal
force-pushed
the
feat/add_stellar_ledger
branch
from
bc25c6b to
8d52b7f
Compare
5 tasks
willemneal
force-pushed
the
feat/add_stellar_ledger
branch
from
beeb1f1 to
1072c21
Compare
willemneal
force-pushed
the
feat/add_stellar_ledger
branch
from
1072c21 to
30e462b
Compare
|
Could this be reopened as a branch on the stellar/stellar-cli repo? |
|
closed in favor of #1627 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This adds the ledger as a possible signer. If a source account is
ledger, the ledger is used to sign the transaction.Depends on #1406
Why
[TODO: Why this change is being made. Include any context required to understand the why.]
Known limitations
Currently having issues with the deps in CI and potentially for end users. Might need to vendor the deps?