Allow for retries when checking if the emulator is running #1459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason we were experiencing intermittent failures with these tests is because when checking if the emulator was fully up and running, sometimes the container wouldn't even be started yet, and would panic in the `wait_for_emulator_start_text` fn. This change adds a retry with exponential backoff so if the container isn't up yet, and the request fails, it will try again after waiting.
leighmcculloch
approved these changes
Jul 16, 2024
|
This PR needs updating to merge. I'm unable to update it because the fork doesn't allow changes from maintainers. |
willemneal
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add a retry when checking to see if the ledger emulator container is fully up and running.
The reason we were experiencing intermittent failures with these tests is because when checking if the emulator was fully up and running, sometimes the container wouldn't even be started yet, and would panic in the
wait_for_emulator_start_textfn. This change adds a retry with exponential backoff so if the container isn't up yet, and the request fails, it will try again after waiting.Closes #1379
Why
These tests were flakey, and it was annoying! 😜
Known limitations
N/A