Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean cargo warnings #1491

Merged
merged 3 commits into from
Jul 26, 2024
Merged

Clean cargo warnings #1491

merged 3 commits into from
Jul 26, 2024

Conversation

Ifropc
Copy link
Contributor

@Ifropc Ifropc commented Jul 25, 2024

What

Cleanup cargo warnings

Why

Cleanup cargo warnings

Known limitations

N/A

Ifropc
Ifropc commented Jul 25, 2024
View reviewed changes
cmd/soroban-cli/Cargo.toml Outdated Show resolved Hide resolved
leighmcculloch
leighmcculloch reviewed Jul 25, 2024
View reviewed changes
Copy link
Member

@leighmcculloch leighmcculloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except we don't need to change the binary main references. Can you remove that change then it's good.

leighmcculloch
leighmcculloch approved these changes Jul 25, 2024
View reviewed changes
Copy link
Member

@leighmcculloch leighmcculloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One ask to rename the other file to stellar.rs, but regardless lgtm. 👍🏻

@leighmcculloch leighmcculloch merged commit 0449dfd into stellar:main Jul 26, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leighmcculloch leighmcculloch leighmcculloch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
DevX
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ifropc @leighmcculloch