-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add error message on system contract #1494
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this. See my comments on stellar/rs-stellar-rpc-client#9.
…m-error-message # Conflicts: # Cargo.lock # cmd/soroban-cli/src/commands/contract/fetch.rs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks! 👏🏻
One comment inline.
To update the CLI Help Doc, run |
What
Add clear error message when trying to fetch asset contract's WASM
cargo run --bin stellar -- contract fetch --rpc-url https://docs-demo.stellar-mainnet.quiknode.pro/ --network-passphrase "Public Global Stellar Network ; September 2015" --id CBBJTE34KZHJACB2A6OXCRTDDLX4LI7GKYYD6XYJSGMX46BLNAG752HS
As the result, moved logic of parsing contract data from rpc client to cli
Why
Previous error message was unclear (see discussion)
Known limitations
N/A