Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bytes from 1.6.0 to 1.6.1 #1495

Merged
merged 2 commits into from
Jul 29, 2024
Merged

Update bytes from 1.6.0 to 1.6.1 #1495

merged 2 commits into from
Jul 29, 2024

Conversation

leighmcculloch
Copy link
Member

@leighmcculloch leighmcculloch commented Jul 29, 2024

What

Update dependency bytes from 1.6.0 to 1.6.1.

Why

Installing stellar-cli with the --locked option is currently displaying a warning that one of the dependencies, bytes 1.6.0, has been yanked.

Usually yanks of a published version are because of something like an accidental publish so we'd want to update urgently and republish so folks can continue to use cargo install --locked. In this case it was just a bug fix and that crate has a different policy for yanking where bugs cause yanks too (tokio-rs/bytes#722).

The bug fix isn't critical to the stellar-cli as far as I can tell, but without updating, cargo install displays warnings which can be worrying to users and result in them running cargo install without --locked which results in untested code from executing.

❯ cargo install --locked stellar-cli
    Updating crates.io index
  Downloaded stellar-cli v21.2.0
  Downloaded 1 crate (30.8 KB) in 0.93s
  Installing stellar-cli v21.2.0
    Updating crates.io index
warning: package `bytes v1.6.0` in Cargo.lock is yanked in registry `crates-io`, consider running without --locked
    Updating crates.io index
...

@leighmcculloch leighmcculloch marked this pull request as ready for review July 29, 2024 03:49
@leighmcculloch leighmcculloch enabled auto-merge (squash) July 29, 2024 03:52
@leighmcculloch leighmcculloch merged commit f0d4720 into main Jul 29, 2024
24 checks passed
@leighmcculloch leighmcculloch deleted the update-bytes branch July 29, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants