Remove lock file from template and update sdk version #1500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ifropc
approved these changes
Jul 29, 2024
cmd/soroban-cli/src/utils/contract-init-template/Cargo.toml.removeextension
Show resolved
Hide resolved
This reverts commit 51ed067.
|
A nodejs test is failing in the e2e tests. |
willemneal
reviewed
Jul 30, 2024
willemneal
approved these changes
Jul 30, 2024
|
@willemneal should this be closed? This PR also includes version bump for |
chadoh
added a commit
to AhaLabs/system-test
that referenced
this pull request
Jul 31, 2024
The system-test started failing in stellar/stellar-cli#1500 because it finally updated the version of `soroban-examples` to use a version that includes stellar/soroban-examples#314. The previous `invoke.ts` logic assumed that the variable would be a Symbol, but the variable has been changed to a String. I don't want to break every project that still uses `system-test` with a stale `soroban-examples` hash, so here's what I did: - dynamically define `contract` using `import()`, using a `@ts-ignore` directive because this can error if `stellar-sdk` doesn't include a `contract` export. - if `contract` is there, then we don't need to know the type of the argument. It could be a Symbol or a String or anything else. - non-`contract` logic path stays unchanged, assuming `Symbol`
leighmcculloch
pushed a commit
to stellar/system-test
that referenced
this pull request
Jul 31, 2024
The system-test started failing in stellar/stellar-cli#1500 because it finally updated the version of `soroban-examples` to use a version that includes stellar/soroban-examples#314. The previous `invoke.ts` logic assumed that the variable would be a Symbol, but the variable has been changed to a String. I don't want to break every project that still uses `system-test` with a stale `soroban-examples` hash, so here's what I did: - dynamically define `contract` using `import()`, using a `@ts-ignore` directive because this can error if `stellar-sdk` doesn't include a `contract` export. - if `contract` is there, then we don't need to know the type of the argument. It could be a Symbol or a String or anything else. - non-`contract` logic path stays unchanged, assuming `Symbol`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1498
What
Remove the Cargo.lock file from init template and update sdk version to v21 without specifying a minor/patch version.
Why
We shouldn't be too prescriptive about the dependencies that folks use, such as providing a Cargo.lock file. Cargo will generate a lock file for them at the point in time they generate their template. This will hopefully prevent us from creating any unexpected inconsistencies such as out of sync ed25519-dalek versions (as was reported).
The CLI should always be encouraging use of the latest SDK, no matter the versions of examples. The CLIs job is to setup a workspace ready to go, and if we've lagged on updating examples we gotta get on that rather than keep the CLI on a past version.
We don't need to specify minor versions for the SDK version. Cargo will select the latest available on the first run.
Close #1498