fix(ts-tests): update js-stellar-sdk; use it correctly #1502
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
stellar-sdk
used by the ts-testsWhy
These tests weren't passing. There's still a couple tests here of the generated types themselves, though #1207 got it right that most of these tests were moved to js-stellar-sdk itself.
Known limitations
Is this workflow too much trouble here to be worth it?
We could generate these types entirely within JS. Maybe within stellar-sdk? Maybe within some other package, run with
npx
or similar? We'd probably want to maintain it in the stellar-sdk monorepo, if it were a monorepo. Then the CLI could just check that you've got NPM installed correctly and runnpx [whatever]
.