Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ts-tests): update js-stellar-sdk; use it correctly #1502

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

chadoh
Copy link
Contributor

@chadoh chadoh commented Jul 30, 2024

What

Why

These tests weren't passing. There's still a couple tests here of the generated types themselves, though #1207 got it right that most of these tests were moved to js-stellar-sdk itself.

Known limitations

Is this workflow too much trouble here to be worth it?

We could generate these types entirely within JS. Maybe within stellar-sdk? Maybe within some other package, run with npx or similar? We'd probably want to maintain it in the stellar-sdk monorepo, if it were a monorepo. Then the CLI could just check that you've got NPM installed correctly and run npx [whatever].

I believe we were running into issues running these tests in CI. Since
they're not running in CI, they get stale quickly.
Copy link

socket-security bot commented Jul 30, 2024

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@stellar/stellar-sdk@12.2.0 Transitive: environment, filesystem, network +26 16.4 MB stellar-npm-ci

View full report↗︎

This fixes 7ab1fcc / stellar#1207, which
mistakenly removed this workflow
@chadoh chadoh requested a review from willemneal July 30, 2024 17:20
@willemneal willemneal merged commit 391be3a into stellar:main Jul 30, 2024
24 checks passed
@willemneal willemneal deleted the fix/ts-tests branch July 30, 2024 18:39
@chadoh chadoh self-assigned this Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants