Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial implementation of rich output with emojis. #1509

Merged
merged 10 commits into from
Aug 6, 2024
Merged

Conversation

fnando
Copy link
Member

@fnando fnando commented Jul 31, 2024

What

Running command with --quiet:

$ stellar contract build && stellar --quiet contract deploy --wasm target/wasm32-unknown-unknown/release/hello_world.wasm --source alice --network testnet
cargo rustc --manifest-path=contracts/hello_world/Cargo.toml --crate-type=cdylib --target=wasm32-unknown-unknown --release
    Finished `release` profile [optimized] target(s) in 0.17s
CDM53PWFXWQGGHUVST644EHZFEQFPL7S3AXN3Q23NR44OCOPWUE6HCVD

Running command and uploading contract for the first time:

$ stellar contract build && stellar contract deploy --wasm target/wasm32-unknown-unknown/release/hello_world.wasm --source alice --network testnet
cargo rustc --manifest-path=contracts/hello_world/Cargo.toml --crate-type=cdylib --target=wasm32-unknown-unknown --release
   Compiling hello-world v0.0.0 (/Users/fnando/Projects/stellar/soroban-hello-world/contracts/hello_world)
    Finished `release` profile [optimized] target(s) in 0.46s
ℹ️ Simulating install transaction…
🌎 Submitting install transaction…
ℹ️ Using wasm hash 48461f23c191d6482cf07d58933642fa9b3daea39dee0b7f7011c55dba2b6694
ℹ️ Simulating deploy transaction…
🌎 Submitting deploy transaction…
🔗 https://stellar.expert/explorer/testnet/tx/109e142001245fc7b0465cdb4b16fc26714d1cadc56f4394b4ed9d3412a73bd4
🔗 https://stellar.expert/explorer/testnet/contract/CBUSXDM33IOGNQQFCLC7Q7AALU4OSIVIBFNHBOFRWFRBLPDTRUNIBCII
✅ Deployed!
CBUSXDM33IOGNQQFCLC7Q7AALU4OSIVIBFNHBOFRWFRBLPDTRUNIBCII

Reusing contract that hasn't changed:

$ stellar contract build && stellar contract deploy --wasm target/wasm32-unknown-unknown/release/hello_world.wasm --source alice --network testnet
cargo rustc --manifest-path=contracts/hello_world/Cargo.toml --crate-type=cdylib --target=wasm32-unknown-unknown --release
    Finished `release` profile [optimized] target(s) in 0.07s
ℹ️ Reusing contract previously uploaded
ℹ️ Using wasm hash 48461f23c191d6482cf07d58933642fa9b3daea39dee0b7f7011c55dba2b6694
ℹ️ Simulating deploy transaction…
🌎 Submitting deploy transaction…
🔗 https://stellar.expert/explorer/testnet/tx/7f8bae8b8f47be2a19182060facbeb6f2433aea9950afd503683fde8471d367f
🔗 https://stellar.expert/explorer/testnet/contract/CB7NGFIYUJVECW4ULO4SQFNLO5IYMEYUYZRVWETEWBGI4FHINENCAB2T
✅ Deployed!
CB7NGFIYUJVECW4ULO4SQFNLO5IYMEYUYZRVWETEWBGI4FHINENCAB2T

Why

So users can have more info when commands are being executed.

Known limitations

N/A

@fnando fnando enabled auto-merge (squash) August 5, 2024 14:52
@fnando fnando requested a review from leighmcculloch August 5, 2024 14:52
Copy link
Member

@leighmcculloch leighmcculloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One ask, otherwise 👍🏻.

cmd/soroban-cli/src/commands/contract/install.rs Outdated Show resolved Hide resolved
@fnando fnando disabled auto-merge August 6, 2024 12:26
@fnando fnando enabled auto-merge (squash) August 6, 2024 12:26
@fnando fnando merged commit 70d56ca into main Aug 6, 2024
26 checks passed
@fnando fnando deleted the tx-verbose branch August 6, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants