Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make global arguments... global. #1510

Merged
merged 4 commits into from
Aug 6, 2024
Merged

Make global arguments... global. #1510

merged 4 commits into from
Aug 6, 2024

Conversation

fnando
Copy link
Member

@fnando fnando commented Jul 31, 2024

What

Make global arguments global, so we can use it independently of the command order.

$ stellar contract deploy --wasm target/wasm32-unknown-unknown/release/hello_world.wasm --source alice --network testnet --quiet
CBGMG2H756O2DP4BDDOPW6F5S6EJBJIMW3TXLDZ33236XS5KWZFN5PRP

$ echo $?
0

^Notice that --quiet is being used at the end of the command.

Why

Better UI/UX.

Known limitations

N/A

@leighmcculloch leighmcculloch marked this pull request as draft August 5, 2024 00:51
@leighmcculloch leighmcculloch marked this pull request as ready for review August 5, 2024 22:11
@fnando fnando merged commit 2c936d5 into main Aug 6, 2024
26 checks passed
@fnando fnando deleted the global-args branch August 6, 2024 12:25
fnando added a commit that referenced this pull request Aug 6, 2024
This conflict was introduced by the move to global switches on pr #1510.
fnando added a commit that referenced this pull request Aug 6, 2024
#1525)

This conflict was introduced by the move to global switches on pr #1510.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants