Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix contract init short name conflict. #1529

Merged
merged 5 commits into from
Aug 7, 2024
Merged

Fix contract init short name conflict. #1529

merged 5 commits into from
Aug 7, 2024

Conversation

fnando
Copy link
Member

@fnando fnando commented Aug 6, 2024

What

Fix contract init short name conflict; -f is also used by filtering.

Why

So users can run the command.

Known limitations

N/A

leighmcculloch
leighmcculloch approved these changes Aug 7, 2024
View reviewed changes
Copy link
Member

@leighmcculloch leighmcculloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One request otherwise lgtm.

cmd/soroban-cli/src/commands/contract/init.rs Outdated Show resolved Hide resolved
@fnando fnando merged commit 0564b5a into main Aug 7, 2024
25 of 26 checks passed
@fnando fnando deleted the fix-contract-init-conflict branch August 7, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leighmcculloch leighmcculloch leighmcculloch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
DevX
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fnando @leighmcculloch