Print status messages when pulling quickstart image #1546
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Closes #1354
To make sure that the user is aware if they are using an up-to-date version of the quickstart image or not, this PR adds some additional logging with that information.
when the image is on the local machine
with internet connection
without internet connection
when the image has not been pulled to the machine
with internet connection
without internet connection
Why
#1354 was to make sure that users are easily able to use the most up-to-date version of a given quickstart image. Since we were already doing
docker pull
anddocker run
onstellar network container start
this is happening already by default, but was not very clear. This PR aims to make that a bit more visible. Also its important to note that if the user already has the most recent version of an image tag, it will not re-download it, but will just verify the local image's digest vs dockerhub to make sure that it's up-to-date.Known limitations
n/a