Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unneeded print statement #1554

Merged
merged 6 commits into from
Aug 30, 2024
Merged

Conversation

willemneal
Copy link
Member

@willemneal willemneal commented Aug 20, 2024

fixes #1539

Also fixes the the json returned is not valid and would have to be edited by the consumer to convert to a JSON list of events.

@leighmcculloch
Copy link
Member

@willemneal There's an e2e test failure.

@willemneal
Copy link
Member Author

@leighmcculloch @chadoh I fixed the e2e test here, but I forget how to update it here since it's not on the stellar repo: stellar/system-test#103

@leighmcculloch
Copy link
Member

I forget how to update it here

There's nothing to update in this repo, just rerun the test after the fix is merged. This repo uses the master branch of the system-test repo.

I've merged stellar/system-test#103 and rerun the failed build:

@willemneal
Copy link
Member Author

willemneal commented Aug 29, 2024

@leighmcculloch Just realized that the e2e tests didn't even expect valid json. Fixed that in this PR and here:

e2e tests now use correct variable stellar/system-test#104

@willemneal willemneal changed the title fix: remove unneeded print statement fix: remove unneeded print statement and print valid json Aug 29, 2024
@willemneal willemneal changed the title fix: remove unneeded print statement and print valid json fix: remove unneeded print statement Aug 30, 2024
@willemneal willemneal merged commit 104089a into stellar:main Aug 30, 2024
26 checks passed
@willemneal willemneal deleted the fix/extra_print branch August 30, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

events: outputs invalid JSON
2 participants