Fix/update init error handling #1584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elizabethengelman
force-pushed
the
fix/update-init-error-handling
branch
2 times, most recently
from
5f69ebe to
4bf46be
Compare
elizabethengelman
force-pushed
the
fix/update-init-error-handling
branch
from
4bf46be to
49fb078
Compare
leighmcculloch
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Return custom errors with context from the init command. This PR comes from a comment on a previous init PR: #1548 (review)
Why
We can reduce the error printing we're doing in individual commands by letting those errors bubble up to the root command. This will also allow the callers of the functions have some more context about the error.
Known limitations
I'm not sure how I feel about the io error handling. Some of these errors were already printing out messages, so I used those messages for the custom error text. Some of the other io errors just returned as is - for those I created a
StdIoerror - partially because it may be overkill tomap_errfor each of those errors. Happy to rethink this piece if folks have other ideas.