Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/cookbook no fund #1599

Closed
wants to merge 2 commits into from
Closed

Fix/cookbook no fund #1599

wants to merge 2 commits into from

Conversation

BlaineHeffron
Copy link
Contributor

@BlaineHeffron BlaineHeffron commented Sep 11, 2024

What

generate command should have --no-fund since we will be moving to that being the default in v22

Why

Make documentation consistent with intended usage of the CLI

Known limitations

N/A

---

To manage the lifecycle of a Stellar smart contract using the CLI, follow these steps:

1. Create an identity for Alice:

```bash
stellar keys generate alice
stellar keys generate alice --no-fund
Copy link
Member

@leighmcculloch leighmcculloch Sep 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems a bit odd to me to push this change where we no fund, then fund immediately after. Nothing appears to be broken in the cookbook without this change, what's the motivation for pushing it out now?

Is anything broken with the script as it is today?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it works fine, I had originally been asked to add --no-fund and explicitly fund it (when I first wrote the guide I just called generate) but when I was testing I had to remove --no-fund because it wasn't working. Anyway, I added it back because Nando was confused as to why we were calling fund afterwards, so this was just adding it back.. but you are right its a bit silly to put it in if this will be the default behavior soon and its already working without it.

@BlaineHeffron BlaineHeffron deleted the fix/cookbook-no-fund branch September 11, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants