Update contract init #1625
Merged
Update contract init #1625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ifropc
force-pushed
the
contract-init-rework
branch
from
272aa0e to
840af02
Compare
fnando
reviewed
Sep 25, 2024
fnando
reviewed
Sep 25, 2024
fnando
reviewed
Sep 25, 2024
fnando
reviewed
Sep 25, 2024
Ifropc
force-pushed
the
contract-init-rework
branch
from
840af02 to
fff708a
Compare
Ifropc
force-pushed
the
contract-init-rework
branch
from
fff708a to
e294872
Compare
|
I'm converting this PR back to draft, I think my original implementation is not what we would like to move forward with |
Ifropc
force-pushed
the
init-deprecate
branch
from
2298378 to
2ea8dee
Compare
# Conflicts: # FULL_HELP_DOCS.md # cmd/soroban-cli/src/commands/contract/init.rs
Ifropc
force-pushed
the
contract-init-rework
branch
from
f040e9e to
8843020
Compare
|
After internal discussion I changed the implementation to keep the current behavior that switches template to the workspace, and make name of generated contract customizable via |
leighmcculloch
approved these changes
Oct 10, 2024
chadoh
added a commit
to AhaLabs/soroban-astro-template
that referenced
this pull request
Dec 9, 2024
The `stellar contract init` command no longer works with `--frontend-template` (stellar/stellar-cli#1625) This means that templates like this one need to hard-code their own list of contracts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Update
contract initimplementation.Now it uses workspace template as the project root and also adds
--namefor easier contract initialization. It's now possible to initialize multiple contracts from a hello world template with passing different--name'sWhy
Changes according to #1586
Known limitations
N/A