Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use reqwest, remove http, ureq and hyper #1632

Merged
merged 11 commits into from
Oct 3, 2024

Conversation

overcat
Copy link
Contributor

@overcat overcat commented Sep 27, 2024

What

We only use reqwest to make HTTP requests in our code, no longer directly using http, ureq, and hyper, to enhance consistency.

Why

fix #1629

Known limitations

N/A

@overcat
Copy link
Contributor Author

overcat commented Sep 27, 2024

CI failed, possibly due to #1631

Copy link
Member

@leighmcculloch leighmcculloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fantastic. One question inline. Also one ask, but it can be deferred and isn't required.

cmd/soroban-cli/src/commands/snapshot/create.rs Outdated Show resolved Hide resolved
cmd/soroban-cli/src/config/network.rs Show resolved Hide resolved
cmd/soroban-cli/src/config/network.rs Outdated Show resolved Hide resolved
cmd/soroban-cli/src/config/network.rs Outdated Show resolved Hide resolved
cmd/soroban-cli/src/upgrade_check.rs Outdated Show resolved Hide resolved
@overcat overcat changed the title Use reqwest and remove http, ureq and hyper Use reqwest, remove http, ureq and hyper Sep 27, 2024
@overcat overcat requested a review from leighmcculloch October 3, 2024 07:14
@leighmcculloch leighmcculloch merged commit 2cb77d2 into stellar:main Oct 3, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Consolidate HTTP client libraries to reduce complexity
2 participants