Add sim-only deprecation notice #1634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ifropc
force-pushed
the
sim-only-deprecation
branch
from
7fa44b4 to
11b4a37
Compare
Ifropc
force-pushed
the
sim-only-deprecation
branch
from
11b4a37 to
641f26f
Compare
# Conflicts: # cmd/soroban-cli/src/utils.rs
leighmcculloch
approved these changes
Oct 10, 2024
cmd/soroban-cli/src/utils.rs
Outdated
| /// Mark argument as deprecated with warning to be printed when it's used. Note: marco is only | ||
| /// supported for `bool` and `String` and is required to add | ||
| /// ``` | ||
| /// use clap::builder::TypedValueParser; |
There was a problem hiding this comment.
Which function call requires this type? We can instead reference the type using the generic as syntax.
There was a problem hiding this comment.
I pushed 3e143cf that removes the need for the use. Have a look at the syntax.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Added following notice when running a command with deprecated flag:
Why
#1547
As the first step, we should add deprecation notice so people have time to migrate off this flag. In the next major release we can remove it.
Known limitations
Added marco needs to include proper
use, see the doc