Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade typescript to latest version #1641

Merged
merged 8 commits into from
Nov 7, 2024
Merged

upgrade typescript to latest version #1641

merged 8 commits into from
Nov 7, 2024

Conversation

Benjtalkshow
Copy link
Contributor

@Benjtalkshow Benjtalkshow commented Oct 1, 2024 •
edited
Loading

closes #1155

Upgrade TypeScript to Latest Version

  • Upgraded TypeScript to the latest stable version and updated tsconfig.json as needed.
  • Refactored code to resolve any type errors introduced by the upgrade.
  • Ran test and manual tests to ensure stability.

@Benjtalkshow Benjtalkshow marked this pull request as draft October 1, 2024 22:21
@socket-security Socket Security
Copy link

socket-security bot commented Oct 1, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@types/[email protected] None +1 2.34 MB types
npm/[email protected] None 0 22.4 MB typescript-bot
npm/[email protected] None 0 22.4 MB typescript-bot

🚮 Removed packages: npm/[email protected]

View full report↗︎

@Benjtalkshow Benjtalkshow marked this pull request as ready for review October 3, 2024 23:22
@Benjtalkshow Benjtalkshow mentioned this pull request Oct 3, 2024
Closed
@Benjtalkshow
Copy link
Contributor Author

@willemneal can you check my PR?

@willemneal willemneal requested a review from chadoh October 4, 2024 16:13
willemneal
willemneal approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@willemneal willemneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'll let @chadoh also approve since he is more familiar

@Benjtalkshow
Copy link
Contributor Author

LGTM! I'll let @chadoh also approve since he is more familiar

Alright

@Benjtalkshow
Copy link
Contributor Author

@willemneal
When are they going to merge this PR?

chadoh
chadoh approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@chadoh chadoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good

@leighmcculloch
Copy link
Member

@chadoh @willemneal Is this okay to be merged?

chadoh
chadoh approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@chadoh chadoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@willemneal willemneal enabled auto-merge (squash) November 6, 2024 22:45
@willemneal willemneal merged commit 794fd44 into stellar:main Nov 7, 2024
28 of 30 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Nov 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willemneal willemneal willemneal approved these changes

@chadoh chadoh chadoh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
DevX
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TS Bindings: Upgrade Typescript to latest
5 participants
@Benjtalkshow @leighmcculloch @chadoh @willemneal @fnando