Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not require source account when fetching an asset's contract id. #1647

Merged
merged 4 commits into from
Oct 3, 2024

Conversation

fnando
Copy link
Member

@fnando fnando commented Oct 2, 2024

What

Close #1645

Why

Because we don't need a source account or hd path to return the asset's contract id.

Known limitations

N/A

@fnando fnando requested a review from leighmcculloch October 2, 2024 23:17
@fnando fnando enabled auto-merge (squash) October 3, 2024 00:09
@fnando fnando merged commit ddad905 into main Oct 3, 2024
25 checks passed
@fnando fnando deleted the fix-contract-id-asset branch October 3, 2024 00:12
@leighmcculloch
Copy link
Member

Beautiful. Love the simplicity of this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

stellar contract id asset requires a source account unnecessarily
2 participants