Do not run npm commands but output instructions instead #1731
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Do not run npm commands but output instructions instead.
Add friendly output describing what's happening in line with other commands that have been recently updated.
Why
To make less assumptions about when and how folks will generate their packages.
It is reasonably simple for folks to run the npm commands afterwards, and it'll be less surprising for folks who don't currently have npm tools installed.
Note that this is a breaking change. Most breaking changes in the CLI are being made in a way that first a warning notice or deprecation notice is displayed in one version, then in a subsequent major version the functionality breaks. But in this case, the change is worth making sooner. Why: Due to past security incidents with packages in the npm ecosystem, straight up calling npm install on someones machine isn't great. There's little reason to force the npm install on folks as they can simply run the command themselves.
Close #1512