Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollback rust toolchain to 1.81.0 #1735

Closed
wants to merge 1 commit into from
Closed

Rollback rust toolchain to 1.81.0 #1735

wants to merge 1 commit into from

Conversation

Ifropc
Copy link
Contributor

@Ifropc Ifropc commented Nov 18, 2024

What

Rolling back toolchain to 1.81.0

Why

Clippy emits false positives on 1.82.0

Known limitations

N/A

Copy link
Member

@fnando fnando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@leighmcculloch
Copy link
Member

We should fix the issues imo rather than pin to the past.

@leighmcculloch
Copy link
Member

We also target 1.81.0

That is the minimum supported rust version, not the target.

@Ifropc
Copy link
Contributor Author

Ifropc commented Nov 18, 2024

We should fix the issues imo rather than pin to the past.

We do use older version in the CI (not sure why) -- as there aren't any clippy failures.
We can pin to 1.81 for now (so clippy at least works locally), and then investigate on both upgrading to the latest in CI and investigating clippy issues (it could be a regression in clippy based on the open issues), WDYT?

@Ifropc
Copy link
Contributor Author

Ifropc commented Nov 19, 2024

Closing in favor of #1741

@Ifropc Ifropc closed this Nov 19, 2024
@Ifropc Ifropc deleted the rollback-rust branch November 19, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants