Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1682: fix build tests #1736

Open
wants to merge 4 commits into
base: 1682-help-tests
Choose a base branch
from
Open

#1682: fix build tests #1736

wants to merge 4 commits into from

Conversation

Ifropc
Copy link
Contributor

@Ifropc Ifropc commented Nov 18, 2024

What

Part of #1682 test fixes. This PR fixes build tests.

Why

As part of #1594 CARGO_BUILD_RUSTFLAGS were added, making existing tests to fail (if RUSTFLAGS are not set).
In addition, according to the documentation --remap-path-prefix should be in format --remap-path-prefix<SPACE>FROM=TO while in #1594 it uses format --remap-path-prefix=FROM=TO

Known limitations

Some unrelated tests fail, see #1682

@Ifropc Ifropc requested a review from a team as a code owner November 18, 2024 19:54
@Ifropc Ifropc requested review from leighmcculloch and fnando and removed request for a team November 18, 2024 19:54
@Ifropc Ifropc force-pushed the 1682-help-tests branch 2 times, most recently from e4b3254 to 2b58f20 Compare November 18, 2024 20:16
Copy link
Contributor

@elizabethengelman elizabethengelman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@brson
Copy link
Contributor

brson commented Dec 8, 2024

I just discovered all these failing tests. Thanks for fixing them @Ifropc.

cc @leighmcculloch oops...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Needs Review
Development

Successfully merging this pull request may close these issues.

4 participants