Remove outdated npm instruction. #1757
Conversation
This instruction doesn't make sense now that `--frontend-template` has been removed.
| print.infoln(format!( | ||
| "Run \"npm install && npm run build\" in {:?} to build the JavaScript NPM package.", | ||
| self.output_dir | ||
| )); |
There was a problem hiding this comment.
We just added this instruction because it is relevant to the typescript bindings, which create an npm package, but the cli no longer installs and builds the package. That is now the job of the user. This command is independent of the frontend template feature that used to exist in the contract init command.
There was a problem hiding this comment.
this instruction won't work unless you follow whatever we had on the template; npm run build is not a standard task and can be something completely different depending on how you set up your project.
Let's say you have a hello smart contract project, and the dapp lives somewhere else, and you're using stellar contract bindings typescript --out-dir ../hello-dapp, then this also is misleading, because I'd run it on the smart contract dir, which is not a js project.
There was a problem hiding this comment.
oh, i just got the message. It doesn't mention the current dir, it mentions the output dir, which has everything mentioned on the task. My bad! 🤦♂️
What
This instruction doesn't make sense now that
--frontend-templatehas been removed.Why
So the output makes sense.
Known limitations
N/A