Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: typos #1779

Closed
wants to merge 7 commits into from
Closed

fix: typos #1779

wants to merge 7 commits into from

Conversation

omahs
Copy link

@omahs omahs commented Dec 4, 2024

fix: typos

janewang
janewang reviewed Jan 17, 2025
View reviewed changes
cmd/soroban-cli/src/commands/network/mod.rs
#[error("Inproper response {0}")]
InproperResponse(String),
#[error("Improper response {0}")]
ImproperResponse(String),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this incorrectly named in multiple places, so I'd not fix in this PR if we are not fix in all the places

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @janewang, I did a search, and this is the only occurrence of this typo

@omahs omahs requested a review from a team as a code owner January 23, 2025 14:28
@janewang
Copy link
Contributor

Closing after discussion

@janewang janewang closed this Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janewang janewang janewang left review comments

@willemneal willemneal willemneal left review comments

Assignees
No one assigned
Labels
None yet
Projects
DevX
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@omahs @janewang @willemneal