feat(ts-bindings): allow generating from wasm hash #1780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chadoh
force-pushed
the
feat/ts-bindings/bind-wasm-hash
branch
3 times, most recently
from
dcb9475 to
f43c544
Compare
Ifropc
reviewed
Dec 9, 2024
chadoh
force-pushed
the
feat/ts-bindings/bind-wasm-hash
branch
2 times, most recently
from
46f4aa5 to
22ad32f
Compare
Refactor spec-fetching logic from `contract::info::shared` so that it can be used for `contract::bindings::typescript` as well. This means that `contract::info` commands now have more logging than they did before, and support global args for quieting these print statements.
chadoh
force-pushed
the
feat/ts-bindings/bind-wasm-hash
branch
from
22ad32f to
e8dc57e
Compare
leighmcculloch
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Allow generating TS Bindings from a wasm hash, instead of only contract ID or wasm file path.
Why
This is useful for generating TS Bindings for wasm files that have been uploaded to the network, but for which no contracts have yet been deployed.
Known limitations (WIP)
main--wasm,--wasm-hash, and--contract-idand DRY up their code.