chore: clean up interface for info::shared::fetch #1802
+146
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wasm files have metadata that isn't currently used by typebindings. However, we were creating a higher level Spec (not just `Vec<ScSpecEntry>`), from the raw bytes of the XDR. Also, add initialization logic in `cmd/crates/soroban-spec-typescript/ts-tests` and a test to show that we can generate typebindings from the native asset. Clean up `ts-tests` logic while here, updating "soroban" references with "stellar".
Follow-up to #1780, implementing @leighmcculloch's [suggestions]. [suggestions]: #1780 (review)
chadoh
force-pushed
the
chore/info-shared-cleanup
branch
from
9ee88d4 to
05c183d
Compare
leighmcculloch
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #1780, implementing
@leighmcculloch's suggestions.
What
Rename
fetch_wasmtofetchand clean up its return value, making all possible return types more understandable.Why
To keep our code clean and maintainable.
Known limitations
main