Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate contract install in favor of contract upload. #1850

Merged
merged 2 commits into from
Jan 28, 2025
Merged

Conversation

fnando
Copy link
Member

@fnando fnando commented Jan 27, 2025

What

Deprecate contract install in favor of contract upload.

$ stellar contract install --wasm target/wasm32-unknown-unknown/release/hello_world.wasm
⚠️ `stellar contract install` has been deprecated in favor of `stellar contract upload`
ℹ️ Skipping install because wasm already installed
89123eaa2902ec32e26db0141e2d0247e5e00846489f4d8b17d597a85466e863

$ stellar contract upload --wasm target/wasm32-unknown-unknown/release/hello_world.wasm
ℹ️ Skipping install because wasm already installed
89123eaa2902ec32e26db0141e2d0247e5e00846489f4d8b17d597a85466e863

Why

Close #1621.

Known limitations

N/A

@fnando fnando self-assigned this Jan 27, 2025
@willemneal
Copy link
Member

This adds an extra entry in the docs which is a little confusing. Though I agree there should be a way to determine if install was used. So 🤷

@fnando fnando merged commit 9b0e523 into main Jan 28, 2025
25 checks passed
@fnando fnando deleted the contract-upload branch January 28, 2025 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

rename install to upload; alias as install
3 participants