-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle restorePreamble in cli prepare_and_send helper #892
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, although I am missing some testing.
@paulbellamy not sure why, but the mac tests are failing. could you fix those ? |
Seems like merging main fixed the mac tests. |
Just a note on where this PR is at: |
@willemneal could you take over the testing? |
Closing this in favor of #931 |
What
Handle the new
restorePreamble
return value fromsimulateTransaction
Why
So that cli invoke still works if any entries need restoring
Todo