Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle restorePreamble in cli prepare_and_send helper #892

Closed
wants to merge 7 commits into from

Conversation

paulbellamy
Copy link
Contributor

What

Handle the new restorePreamble return value from simulateTransaction

Why

So that cli invoke still works if any entries need restoring

Todo

  • test it

Copy link
Contributor

@2opremio 2opremio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, although I am missing some testing.

@tsachiherman
Copy link
Contributor

@paulbellamy not sure why, but the mac tests are failing. could you fix those ?

@paulbellamy
Copy link
Contributor Author

Seems like merging main fixed the mac tests.

@paulbellamy
Copy link
Contributor Author

paulbellamy commented Aug 28, 2023

Just a note on where this PR is at:
I'm not really sure where to go with testing this at the moment... I can't (currently) seem to get a working standalone quickstart/rpc/cli/contract with a matching xdr version. And trying to refactor the cli/rpc client so it could be mocked & unit tested is extremely painful, due to the rust jsonrpsee traits (but maybe possible?) :/

@2opremio
Copy link
Contributor

2opremio commented Aug 28, 2023

@willemneal could you take over the testing?

@mollykarcher
Copy link
Contributor

Closing this in favor of #931

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants