Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: try invoking CLI from go test #927

Merged
merged 11 commits into from
Sep 7, 2023
Merged

feat: try invoking CLI from go test #927

merged 11 commits into from
Sep 7, 2023

Conversation

willemneal
Copy link
Member

What

Invoke the rust CLI from a go integration test

Why

This will allow testing the CLI against the same RPC server in the repo and not rely on quickstart.

Known limitations

[TODO or N/A]

@willemneal willemneal marked this pull request as ready for review September 6, 2023 00:28
@willemneal willemneal force-pushed the feat/CLI_integration_tests branch from 9d6583f to d8f9e20 Compare September 6, 2023 15:16
tsachiherman
tsachiherman reviewed Sep 6, 2023
View reviewed changes
Copy link
Contributor

@tsachiherman tsachiherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one more request

cmd/soroban-rpc/internal/test/simulate_transaction_test.go Outdated Show resolved Hide resolved
@tsachiherman tsachiherman dismissed their stale review September 6, 2023 15:59

issue was resolved.

@willemneal willemneal merged commit 16ada04 into stellar:main Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsachiherman tsachiherman tsachiherman left review comments

@2opremio 2opremio 2opremio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@willemneal @2opremio @tsachiherman