Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: Remove explicit decoding depths #950

Merged
merged 5 commits into from
Sep 13, 2023
Merged

cli: Remove explicit decoding depths #950

merged 5 commits into from
Sep 13, 2023

Conversation

2opremio
Copy link
Contributor

No description provided.

@2opremio 2opremio requested a review from willemneal September 11, 2023 21:29
@2opremio 2opremio force-pushed the remove-explicit-decoding-depths branch from aa45a6e to 476409d Compare September 11, 2023 21:31
leighmcculloch
leighmcculloch approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@leighmcculloch leighmcculloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call.

leighmcculloch
leighmcculloch reviewed Sep 11, 2023
View reviewed changes
Copy link
Member

@leighmcculloch leighmcculloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, maybe we should make this an option? i.e. The default being limits in place for untrusted data, but dev can switch it off in other cases?

@2opremio
Copy link
Contributor Author

Actually, maybe we should make this an option? i.e. The default being limits in place for untrusted data, but dev can switch it off in other cases?

we can do that later if need be

@2opremio 2opremio enabled auto-merge (squash) September 12, 2023 07:12
@2opremio 2opremio merged commit 803bb76 into main Sep 13, 2023
20 of 22 checks passed
@2opremio 2opremio deleted the remove-explicit-decoding-depths branch September 13, 2023 12:55
@2opremio 2opremio restored the remove-explicit-decoding-depths branch September 13, 2023 15:07
2opremio added a commit that referenced this pull request Sep 13, 2023
@2opremio
Revert "cli: Remove explicit decoding depths (#950)"
cd3d860 
This reverts commit 803bb76.
@2opremio 2opremio mentioned this pull request Sep 13, 2023
Merged
2opremio added a commit that referenced this pull request Sep 13, 2023
@2opremio
Revert "cli: Remove explicit decoding depths (#950)" (#958)
06bf51f 
This reverts commit 803bb76.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leighmcculloch leighmcculloch leighmcculloch approved these changes

@willemneal willemneal willemneal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@2opremio @leighmcculloch @willemneal