Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrades generated TypeScript bindings to the latest soroban-client #964

Merged
merged 13 commits into from
Sep 14, 2023

Conversation

Shaptic
Copy link
Contributor

@Shaptic Shaptic commented Sep 13, 2023

What

This upgrades soroban-client to v1.0.0-beta.2 and migrates the project template code accordingly. The changes can be summarized as:

  • leveraging the new string -> ScVal { ScAddress } capability of nativeToScVal
  • dealing with the new SimulateTransactionResponse schema
  • leveraging the new GetTransactionStatus enum

Why

Self-explanatory: staying up to date with the pending testnet release.

@Shaptic Shaptic added the Testnet August 2023 Release The release of the Soroban platform to testnet label Sep 13, 2023
@Shaptic Shaptic added this to the Soroban Testnet Release milestone Sep 13, 2023
Copy link
Contributor

@tsachiherman tsachiherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one.

Copy link
Contributor

@sreuland sreuland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for resolving this, soroban-examples-dapp uses the ts bindings, so this will help greatly in bringing that up to latest release as well.

Copy link
Member

@willemneal willemneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one nit.

@Shaptic Shaptic enabled auto-merge (squash) September 14, 2023 20:50
@Shaptic Shaptic merged commit 7d3b417 into stellar:main Sep 14, 2023
20 of 21 checks passed
@Shaptic Shaptic deleted the bump-ts-bindings branch September 14, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testnet August 2023 Release The release of the Soroban platform to testnet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants