-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add way to invoke cargo from go code in effort to reuse rust tests #967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can you please rebase, to make the changes more readable? Thanks! |
willemneal
force-pushed
the
feat/go_cargo_test
branch
2 times, most recently
from
September 15, 2023 14:42
eddf945
to
a04f17c
Compare
2opremio
reviewed
Sep 18, 2023
2opremio
reviewed
Sep 18, 2023
willemneal
force-pushed
the
feat/go_cargo_test
branch
from
September 18, 2023 14:57
742ff99
to
c952367
Compare
CI for integration tests now take 26 min, which is still less than e2e, but not ideal. |
2opremio
approved these changes
Sep 19, 2023
willemneal
force-pushed
the
feat/go_cargo_test
branch
4 times, most recently
from
September 21, 2023 18:29
ece470f
to
e39b05b
Compare
Currently the test uses a sleep because it has been a struggle to get an entry's expiration
First example of using `cargo test` from the go code.
Currently the test uses a sleep because it has been a struggle to get an entry's expiration
Since other tests will deploy hello_world this adds nothing
willemneal
force-pushed
the
feat/go_cargo_test
branch
from
September 22, 2023 16:42
e39b05b
to
c474117
Compare
willemneal
force-pushed
the
feat/go_cargo_test
branch
from
September 23, 2023 14:13
5e453a8
to
5380a70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Depends on #931. Invoke specific rust tests from go passing the network configuration via env vars.
Add tests for checking SAC tokens can be deployed.
Why
Reuse rust tests and allow new tests to be written in Rust.
Known limitations
[TODO or N/A]