Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

soroban-rpc: preflight: Exclude temporary expired entries from SnapshotSource #980

Merged
merged 4 commits into from
Sep 21, 2023

Conversation

2opremio
Copy link
Contributor

No description provided.

Copy link
Member

@leighmcculloch leighmcculloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this something we can include a test for?

@2opremio
Copy link
Contributor Author

Hold on, this is still broken

@2opremio 2opremio force-pushed the stop-including-temp-expired branch from 8765760 to 30b6821 Compare September 20, 2023 23:08
@2opremio
Copy link
Contributor Author

2opremio commented Sep 20, 2023

Alright, this should be it.

Is this something we can include a test for?

Probably, but it's 1 am here :) , feel free to add one if we want to release this fast

@2opremio 2opremio force-pushed the stop-including-temp-expired branch from 01f338f to 2d8c9a7 Compare September 20, 2023 23:57
Copy link
Member

@leighmcculloch leighmcculloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not an expert in this area of code, but the changes look like they make sense.

@tsachiherman tsachiherman merged commit f011f52 into stellar:main Sep 21, 2023
21 checks passed
@2opremio 2opremio deleted the stop-including-temp-expired branch September 21, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants