Feat(CLI): add key::Args and FullLedgerEntry/FullLedgerEntries
#981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willemneal
force-pushed
the
feat/add_key_args
branch
from
dcbcc04 to
694d68d
Compare
2opremio
approved these changes
Sep 22, 2023
Closed
|
@tsachiherman it seems you merged this with broken integration tests :( |
Ahh.. I didn't notice that. I guess we'll need to either pr a fix or revert the change. |
|
Actually they seem to have passed here but failed when run in main |
|
See #987 . @willemneal PTAL, I've assigned it to you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Created a new args struct for creating ledger keys. Also adds a new method and new types to the
rpc, which helps return a struct containing an entry's expiration.Improve error handling bump/restore to ensure that checks a keys expiration if it fails to bump. Reporting to user that it was a no-op.
Now durability is required, but we could could persistent as the default, as I'm sure it will be for most people.
I also picked a max ledgers to bump based on trial and error, but could use on official one.
And in the case where the ledger is before the expiration, the current expiration is returned.
Also updated read command to return the current expiration, though could use feedback on updating args if needed.
Why
fix #969
Known limitations
[TODO or N/A]