Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a simple mechanism for users to increase the initial Soroban settings limits #3897

Closed
sisuresh opened this issue Aug 28, 2023 · 6 comments · Fixed by #3901
Closed

Comments

@sisuresh
Copy link
Contributor

The initial Soroban settings are low so when we launch on testnet, they'll be in what we call "safe mode". The issue with this is that users that are testing on a fresh local network will have issues with hitting the low max values. We should provide a simple way to increase these value.

@MonsieurNicolas
Copy link
Contributor

This is probably related to #3822 and/or #3863 ?

@sisuresh
Copy link
Contributor Author

Yeah but the current mechanisms are too complex for users to rely on. I think for now the simplest this is to provide a boolean config flag called TESTING_HIGH_SOROBAN_LIMITS and just set values to something we don't expect users to hit.

@MonsieurNicolas
Copy link
Contributor

In which scenario would we use this? In testnet we will not use this: we have to follow production procedures

@sisuresh
Copy link
Contributor Author

This would be used for standalone quickstart and platform e2e tests.

@MonsieurNicolas
Copy link
Contributor

As a short term band-aid this could be enough if you're trying to unblock e2e testing.

That being said, in e2e tests and standalone, I imagine that some tests will want to use values that are in production?

In the linked issue I thought people would prepare a few "profiles" that match whatever scenario people expect to test.

Similarly, even in core supercluster missions, we'll need "high tps" profiles that allow to properly flood transactions.

@sisuresh
Copy link
Contributor Author

Yeah this is a quick fix. We need to add someway for users to set settings to our different "phases".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants
@MonsieurNicolas @sisuresh and others